unnecessary variable cleanup

This commit is contained in:
zawz 2019-06-17 02:04:14 +02:00
parent 94e534f151
commit c146f55d48
3 changed files with 6 additions and 10 deletions

View file

@ -9,9 +9,8 @@ class NoteCommand
{ {
public: public:
NoteCommand(uint8_t i, int8_t ch, uint8_t l, uint8_t h, std::string sh); NoteCommand(int8_t ch, uint8_t l, uint8_t h, std::string sh);
uint8_t id;
int8_t channel; int8_t channel;
uint8_t low; uint8_t low;
uint8_t high; uint8_t high;
@ -22,9 +21,8 @@ class ControllerCommand
{ {
public: public:
ControllerCommand(uint8_t i, int8_t ch, uint8_t l, uint8_t h, float ml, float mm, bool fl, std::string sh); ControllerCommand(int8_t ch, uint8_t l, uint8_t h, float ml, float mm, bool fl, std::string sh);
uint8_t id;
int8_t channel; int8_t channel;
uint8_t min; uint8_t min;
uint8_t max; uint8_t max;

View file

@ -1,17 +1,15 @@
#include "command.hpp" #include "command.hpp"
NoteCommand::NoteCommand(uint8_t i, int8_t ch, uint8_t l, uint8_t h, std::string sh) NoteCommand::NoteCommand(int8_t ch, uint8_t l, uint8_t h, std::string sh)
{ {
this->id=i;
this->channel=ch; this->channel=ch;
this->low=l; this->low=l;
this->high=h; this->high=h;
this->shell=sh; this->shell=sh;
} }
ControllerCommand::ControllerCommand(uint8_t i, int8_t ch, uint8_t l, uint8_t h, float ml, float mh, bool fl, std::string sh) ControllerCommand::ControllerCommand(int8_t ch, uint8_t l, uint8_t h, float ml, float mh, bool fl, std::string sh)
{ {
this->id=i;
this->channel=ch; this->channel=ch;
this->min=l; this->min=l;
this->max=h; this->max=h;

View file

@ -154,7 +154,7 @@ bool Device::import_chunk(Chunk const& ch)
for( uint8_t i=id_low ; i <= id_high ; i++ ) for( uint8_t i=id_low ; i <= id_high ; i++ )
{ {
this->noteCommands[i].push_back(NoteCommand(i,channel,low,high,shell)); this->noteCommands[i].push_back(NoteCommand(channel,low,high,shell));
} }
this->nb_command++; this->nb_command++;
} }
@ -188,7 +188,7 @@ bool Device::import_chunk(Chunk const& ch)
for( uint8_t i=id_low ; i <= id_high ; i++ ) for( uint8_t i=id_low ; i <= id_high ; i++ )
{ {
this->ctrlCommands[i].push_back(ControllerCommand(i,channel,min,max,mapMin,mapMax,floating,shell)); this->ctrlCommands[i].push_back(ControllerCommand(channel,min,max,mapMin,mapMax,floating,shell));
} }
this->nb_command++; this->nb_command++;
} }